Improve sidecar startup error for unknown action class#181
Merged
luca-iachini merged 4 commits intoJun 21, 2026
Conversation
luca-iachini
force-pushed
the
fir-284-improve-error-sidecar-startup-message
branch
from
395f0f2 to
b59e4ac
Compare
| @@ -113,7 +113,12 @@ impl MappingTable { | |||
| for (i, rule_cfg) in file.rules.iter().enumerate() { | |||
| if !registry.contains(&rule_cfg.action_class) { | |||
Contributor
There was a problem hiding this comment.
Do we have a test that hits this error path?
Contributor
Author
There was a problem hiding this comment.
We already have them, but I took the opportunity to refactor them to use clearer names and improve the assertions.
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
Comment on lines
+316
to
+320
| assert_matches!( | ||
| err, | ||
| MappingTableError::DuplicateRule { index: 1, ref rule } | ||
| if rule.action_class == "code.review.read" | ||
| ); |
Contributor
There was a problem hiding this comment.
For errors that may end up being user-facing, let's use insta to ensure they render as we expect.
luca-iachini
force-pushed
the
fir-284-improve-error-sidecar-startup-message
branch
from
1182cf0 to
9aabde5
Compare
LukeMathWalker
approved these changes
Jun 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Improves the startup error raised by
MappingTable::from_configwhen a mapping rule references an action class not in the built-in FEP registry.New message explains:
schema_pathin[authority]only affects Cedar policy validation in theAuthority — it does not extend this registry (a common point of confusion), and
Changes
crates/firma-sidecar/src/normalizer/mapping.rs— expand the error string