Skip to content

Blur and noise effects to the background image#15

Open
ArtemMozharov wants to merge 1 commit into
FireIsGood:mainfrom
ArtemMozharov:main
Open

Blur and noise effects to the background image#15
ArtemMozharov wants to merge 1 commit into
FireIsGood:mainfrom
ArtemMozharov:main

Conversation

@ArtemMozharov

Copy link
Copy Markdown

Hello Team,

I have added some blur and noise features to the background image. Both can be edited, but the default settings are also ok. I would be grateful if you do confirm my pull request, as I love your theme. If you do, could you please find a noise texture that is better. This one the best I could find, and I am in-between of CS exams and don't have time unfortunately to invest into my fork of your theme. Here is how it looks with my setup:

image

Anyway, love your theme, thanks for creating it, have a great day and good luck!

Best,

Artem

PS: the URL to the noise texture is hardcoded, maybe you could create a gallery of different noises or how it is done in "Blur my Shell" Gnome extension you could generate the noise yourself. Idk, maybe after exams I could look into it :)

@FireIsGood

Copy link
Copy Markdown
Owner

Hi Artem,

Thanks for your interest in the project! I originally considered adding these sorts of options but I found that the effects cause a slight lag that was noticeable on my machine. These are neat additions, though there are some issues with some parts.

For the commit you sent in you have over 400 line changes even though it should only be about 20 additions. I think you have a different formatter as the project uses Prettier with the provided prettier.toml to format everything. To prevent a lot of extra diff changes if merged, could you run prettier locally and make a commit so that the diff here only shows the relevant changes?

Regarding the noise texture, Obsidian's theme policy is that you cannot load remote images. Some stuff regarding telemetry. To include the noise texture, you'd have to modify it to be similar to the background image setup with a image URL that the user can add or (more performance demanding (from vibes) on the computer) use a base 64 encoded image. I'm personally not a fan of adding entire fonts and images to my theme so it would probably just be the former with a second image that users could overlay.

For the filter, it is set as default of on at 5 px blur. This would change default behavior which I would not like to force upon existing users. You would would have to make it have a toggle with the default as off to prevent such issues. Extremely similar to how the background-image part works. I'm also not sure exactly if filter() causes performance penalties even at 0 but I wouldn't want to chance it.

For some nitpicks with the changes you made, I would prefer if you moved the background image comment at line 1911 so it's a bit more organized. I assume you moved it out of the horizontal main container for style, though I haven't checked out your local copy in depth.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants