Repository navigation
refactor: address the review of #147 - #148
Merged
Merged
Conversation
- get_coordinates and get_nearest_index of obstructions and their parts take an
optional quantity, since node-based and cell-centred quantities have
different coordinates; without it they keep using the first quantity loaded.
- Obstruction.vmin/vmax skip parts without the quantity, like the global
arrays do, and raise KeyError only if no part has it.
- sim.meshes.get_global_boundary_data_arrays returns {} for a case without
boundary data, like an obstruction without boundary data; Mesh has
has_boundary_data.
- Combining node-based and cell-centred patches of one quantity raises
ValueError instead of placing them on one grid.
- The bndf_domain and bndf_global inputs use DB instead of MB vents with
several meshes, and one namelist per line (FDS reads only the first), and
are rerun with FDS 6.11.1.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #147 from its review.
get_coordinatesandget_nearest_indexofObstructionandSubObstructiontake an optionalquantity: node-based and cell-centred quantities have different coordinates. Without it they keep using the first quantity loaded, as before.Obstruction.vmin/vmaxskip parts of the obstruction that have no data for the quantity, likeget_global_boundary_data_arraysdoes, and raiseKeyErroronly if no part has it.sim.meshes.get_global_boundary_data_arraysreturns{}for a case without boundary data, like an obstruction without boundary data does.Mesh.has_boundary_datais new.ValueErrorinstead of placing them on one grid.bndf_domainandbndf_globaluseDBinstead ofMBvents with several meshes (the FDS User Guide recommendsDBfor the domain boundary) and one namelist per line, rerun with FDS 6.11.1.Tests
New tests for the coordinates of a chosen quantity, the orientation filter of
Obstruction.get_boundary_data, parts without the quantity, mixed node-based and cell-centred patches, and a case without boundary data.🤖 Generated with Claude Code