Repository navigation
fix: steps columns as in the FDS User Guide; GeomSlice array hint - #141
Merged
Merged
Conversation
… hint sim.steps stored the wall-clock time of CHID_steps.csv under "Time Step", which the FDS User Guide (section "Time Step Data") defines as the iteration number, and did not read the iteration number at all. It now has "Step" (iteration number) and "Wall Time" (UTC). "Time Step" keeps the wall-clock time for compatibility and warns once (FutureWarning) that it will become the iteration number. The TypeError for converting a GeomSlice to a numpy array recommended to_global, which GeomSlice does not have; it now names the data, vertices and faces properties. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sim.stepsThe FDS User Guide (section "Time Step Data") documents
CHID_steps.csvas:where Time Step is the current time step (iteration number) and Wall Time the date and time. fdsreader stored the wall-clock time under
"Time Step"and never read the iteration number."Step""Wall Time"datetime64[ms], UTC"Time Step"FutureWarning) that it will become the iteration number"Step Size","Simulation Time","CPU Time"stepsis now aStepData(adictsubclass) so that only reading"Time Step"warns; existing code keeps working. The simulation cache format is bumped so cached simulations get the new keys.GeomSlicearray hintnp.asarray(geomslice)raised aTypeErrorrecommendingto_global, whichGeomSlicedoes not have. The hint is now a class attribute;GeomSlicenames itsdata,verticesandfacesproperties, which combine all meshes.Tests
tests/test_steps_and_array_hints.py: the steps columns, the one-time warning (also through.get) and both array hints. The timezone test from #139 now reads"Wall Time".🤖 Generated with Claude Code