Repository navigation
Keep immutable sprite frame times beside their animation counters - #579
Open
BonsUnleashed wants to merge 1 commit into
Open
BonsUnleashed wants to merge 1 commit into
BonsUnleashed wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Invisible animated sprites still advance their frame counters every tick. Finding each frame's duration currently follows the ticker, animation, frame list and frame object. This copies immutable frame durations into an array beside the ticker, so that path needs one array lookup.
Mutable or unfamiliar lists keep the existing lookup, as do invalid frame indices. The counters advance in the same order, and visible sprites keep their normal upload path.
The equivalent patch is prepared for Bons and Furious 1.0.30. Its earlier comparison against the real Embeddium classes checked 1.2 million ticks, including mutable lists, unusual durations and matching exceptions, with no differences. This upstream port passes
compileJava; the branch itself has not been run in game.