basic zn_pow2 ring implementation#24
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Simon!
I implemented the bare minimum needed to get a galois extension working.
I'm not sure everything is correct, namely Integer ring homomorphisms.
There are more things needed to be added, serialisation & hashing, and probably more.
I would appreciate you pointing these out, and also what is important to test in the current and future code.
regarding SmallVecs. I figured that RustBigInts can't be used here because you really want the u64 limbs here. Vecs are heap allocated, with SmallVec you get the same ergonomics but better locality for small <256bit moduli. Let me know your thoughts.