Skip to content

fix: reject stale upstream documentation publications - #12

Merged
zackees merged 1 commit into
gh-pagesfrom
fix/reject-stale-publications
Oct 22, 2026
Merged

zackees merged 1 commit into
gh-pagesfrom
fix/reject-stale-publications

Conversation

@zackees

@zackees zackees commented Oct 22, 2026

Copy link
Copy Markdown
Member

Change

Reject a documentation check when the valid upstream publication generation is numerically older than the valid deployed generation. This stops the observed CDN propagation race before build/deploy. Document retry behavior.

Real production evidence

During #9 verification, run 39730808922 imported generation 39729808961-1 correctly. An immediate subsequent check, run 39731107060, received cached upstream generation 39728951124-1 while the deployed mirror was newer and imported the older output. The actual HTTP fixture now reproduces this ordering and rejects it.

Verification

  • New regression failed before the production change (stale-red.log), passes afterward.
  • All 11 site tests pass; invalid current-marker recovery and strict upstream validation remain covered.
  • Ruff lint/format and git diff --check pass.
  • Existing primary reviewer: clean, no findings.

Contributes to #9; after merge, verify the push restores the newest publication and the live endpoints agree.

@coderabbitai

coderabbitai Bot commented Oct 22, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 33 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 59ec48e9-284b-4798-99cf-ae43be565afa
📥 Commits

Reviewing files that changed from the base of the PR and between 6f24625 and c470960.

📒 Files selected for processing: 3
  • README.md
  • scripts/import_docs.py
  • scripts/test_import_docs.py
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@zackees
zackees merged commit 26efd07 into gh-pages Oct 22, 2026
1 of 2 checks passed
@zackees
zackees deleted the fix/reject-stale-publications branch October 22, 2026 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

1 participant