Skip to content

test(cli): report the runner error in the issue 208 pipe-writer test #290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zackees merged 1 commit into from
Nov 3, 2026
Merged

test(cli): report the runner error in the issue 208 pipe-writer test #290

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion crates/fastled-cli/src/test_mode.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -807,7 +807,11 @@ mod tests {
.await
.expect("command runner task did not complete before the test deadline")
.unwrap();
assert!(result.is_ok());
// Report the runner's message: this has failed intermittently
// on hosted macOS runners and a bare is_ok() hid the cause.
if let Err(error) = result {
panic!("command runner returned an error: {error}");
}
async_engine::sleep(Duration::from_millis(300)).await;
assert!(!temp.path().join("late.txt").exists());
});
Expand Down
Loading