Validate ephemeral containers in per-container checks#1204
Open
kanywst wants to merge 1 commit into
Open
Conversation
Per-container schema checks only iterated init and regular containers, so a privileged ephemeral container passed every container-level check. Add an EphemeralContainers loop alongside the existing two; EphemeralContainerCommon converts to corev1.Container and reuses applyContainerSchemaChecks. Fixes FairwindsOps#1203
kanywst
requested review from
jdesouza,
sudermanjr and
vitorvezani
as code owners
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #1203
Checklist
Description
What's the goal of this PR?
Run the per-container checks against ephemeral containers. Today they only cover init and regular containers, so a privileged ephemeral container passes every container-level check.
What changes did you make?
Added an
EphemeralContainersloop inapplyControllerSchemaChecks(pkg/validator/schema.go) alongside the init and regular container loops.EphemeralContainer.EphemeralContainerCommonconverts tocorev1.Container, so it reusesapplyContainerSchemaChecks. Added a test that a privileged ephemeral container is now evaluated.What alternative solution should we consider, if any?
None.