Add --ignore-kinds flag to exclude resource kinds from results#605
Open
Kunalbehbud wants to merge 1 commit into
Open
Add --ignore-kinds flag to exclude resource kinds from results#605Kunalbehbud wants to merge 1 commit into
Kunalbehbud wants to merge 1 commit into
Conversation
Adds a StringSlice flag that filters matched deprecations by the kind of the deprecated apiVersion, mirroring the existing --components filter semantics. Includes FilterOutput unit tests and docs. Fixes FairwindsOps#399
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #399
Adds an
--ignore-kindsflag that excludes specific resource kinds from the results, as discussed in the issue:It mirrors the existing
--componentsfilter semantics: aStringSliceflag threaded into the API instance, applied inFilterOutputagainst the kind of the matched deprecated apiVersion. The match is case-sensitive (CronJob,Ingress, ...). Since flags are bound automatically,PLUTO_IGNORE_KINDSworks as well and is documented alongside the flag indocs/advanced.md.Scope note: this deliberately doesn't touch the custom-versions-file discussion from the second comment on the issue — that's a separate concern.
Testing
Added a table-driven
TestFilterOutputcovering: no ignored kinds (unchanged behavior), one kind excluded, all kinds excluded.