Repository navigation
docs: fix fleet deployment example line continuations - #925
Draft
rayanakarthikeyan wants to merge 3 commits into
Draft
rayanakarthikeyan wants to merge 3 commits into
rayanakarthikeyan wants to merge 3 commits into
Conversation
1 of 5 tasks
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
|
Thanks @rayanakarthikeyan for your contribution to Failproof AI! 🙌 We'd love to discuss your PR and welcome you to our community. Discord: https://discord.befailproof.ai/ |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The Cloud CLI README places inline comments after the backslashes in the multi-line
fp fleet deployexample. A shell treats each backslash as escaping a space instead of continuing the command, so copying the example splits it into separate commands and fails on the following--add/--removelines.Move the explanations onto their own lines before the example, leaving each continuation backslash at the end of its line. Include a dated documentation changelog entry.
Type of Change
Validation
fpstub, then confirmed the revised example exits successfully and passes both--addpairs and the--removepair to a single call. The stub performs no deployment or network access.git diff --checkpasses.Checklist
bun run lintpassesbunx tsc --noEmitpassesbun run test:runpassesbun run buildsucceedsReplaces #924 after a source-branch naming cleanup. The original commits and draft status are preserved.