ci: ワークフロー統合と protobuf 検証ジョブの追加#281
Merged
Merged
Conversation
FRICK-ELDY
commented
Mar 27, 2026
Owner
- ci.yml.ignore を ci.yml に統合(pull_request・concurrency・各ジョブ)
- proto-verify: protoc / mix alchemy.gen.proto / format 後に git diff
- Rust fmt、Logger.warning、生成 .pb.ex と周辺の mix format 修正
There was a problem hiding this comment.
Code Review
This pull request primarily focuses on code formatting and style consistency across Elixir and Rust files. Key changes include updating deprecated Logger.warn/1 calls to Logger.warning/1 to align with modern Elixir standards, standardizing the syntax in generated Protobuf Elixir modules by adding parentheses to macro calls, and various whitespace and indentation adjustments to improve readability. I have no feedback to provide as the changes are stylistic or address deprecations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.