Repository navigation
add ftcrule command - #506
Merged
Merged
Conversation
devyntk
previously approved these changes
Oct 26, 2026
devyntk
left a comment
devyntk
left a comment
Member
There was a problem hiding this comment.
There are some implementation details here that are a bit odd to me (why do we have two matching groups in the rule regex when we just smash them together in the only usage of them?) that just appear to be from the original implementation and not net-new code. Approved and maybe worth doing a bigger cleanup in the future.
devyntk
approved these changes
Oct 26, 2026
tweirtx
approved these changes
Oct 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FRCTools supports FTC now that FTC uses a single manual and so an
ftcrulecommand is easy to add :)