Solution to expand eLCI mapping for non-FEDEFL water flows#221
Merged
Conversation
bl-young
reviewed
Mar 11, 2026
| eLCI,"NMVOC, non-methane volatile organic compounds, unspecified ",,emission/air,kg,=,1,Volatile organic compounds,6f861846-1c4c-3fc9-a198-56b2d9abd83b,emission/air,kg,Hottle,Edelen,2/5/2020 | ||
| eLCI,"NMVOC, non-methane volatile organic compounds, unspecified",,emission/air,kg,=,1,Volatile organic compounds,6f861846-1c4c-3fc9-a198-56b2d9abd83b,emission/air,kg,Hottle,Edelen,2/10/2020 | ||
| eLCI,water,,resource,kg,=,1,Water,8ba7dd57-b502-397b-944a-f63c6615f754,resource/water,kg,Young,Davis,3/9/2026 | ||
| eLCI,water,,resource/in water,kg,=,1,Water,8ba7dd57-b502-397b-944a-f63c6615f754,resource/water,kg,Young,Davis,3/9/2026 |
Collaborator
There was a problem hiding this comment.
these two rows - the UUID aligns with "Water, fresh". So you'll need to update the flow name or change the UUID
bl-young
requested changes
Mar 11, 2026
bl-young
left a comment
bl-young
left a comment
Collaborator
There was a problem hiding this comment.
Tests indicate only two failures so hopefully that fix resolves it.
Align resource/water to FEDEFL resource/water/water, fresh
Contributor
Author
|
Thanks, Ben. I addressed the two flows in the latest push. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Aside from a long history of merging with master, this commit adds a line to the git ignore list, and proposes 9 additions to the eLCI.csv as discussed in NETL-RIC/ElectricityLCI#313.