[CI] Fixes argilla integration tests#76
Merged
Merged
Conversation
JonnyTran
force-pushed
the
fix-argilla-integration-tests
branch
from
6d0c15e to
184d610
Compare
17 tasks
…12, and exclude PNG files from watcher
…dencies - Updated elasticsearch to 8.17.0 in `argilla-hf-spaces`
…dling - Updated Document model to include new fields: file_name, reference, and improved ID handling. - Refactored API schemas to use DocumentCreate and DocumentDelete for better clarity. - Added from_file method to Document for creating instances from file paths or URLs. - Enhanced error handling in add_document CLI command with debug option. - Updated upload_file function to streamline file upload process and improve user feedback.
- Revised test commands in developer documentation to include coverage options. - Updated development setup instructions to install additional dependencies and clarified Docker deployment steps. - Enhanced clarity in Docker image build instructions and added commands for running the Argilla Server.
- Fixed all integration tests - Added new fields to the Document model: file_name and reference for improved metadata management. - Updated the WorkspacesAPI to handle document creation from both file paths and URLs. - Enhanced CLI commands for adding documents to include reference and improved error handling. - Modified document listing and file upload functionalities for better user experience and feedback. - Updated rich table display to include file names in document listings.
- Added patching for UUID generation in test_get_documents to ensure consistent test results. - Included new fields (file_name and reference) in the document creation test for better metadata handling. - Minor adjustments to the Dockerfiles for improved clarity and consistency.
JonnyTran
changed the title
There was a problem hiding this comment.
Pull Request Overview
This PR fixes issues in the Argilla integration tests and enhances document handling by:
- Cleaning up CLI commands, adding
referenceanddebugoptions toadd_document - Expanding the
Documentmodel withfrom_fileand updated payload serialization - Introducing
LocalFileStoragefor S3-like operations and updating file‐IO in the server context
Reviewed Changes
Copilot reviewed 34 out of 34 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| argilla/src/argilla/cli/documents/add.py | Added reference and debug flags; updated call to add_document |
| argilla/src/argilla/_models/_documents.py | Expanded Document schema, added from_file constructor, payload methods |
| argilla-server/src/argilla_server/contexts/files.py | Implemented local file storage, updated put_object/get_object to use ObjectWriteResult and HTTPResponse |
| (other files) | Various imports, schema renames, devcontainer/Dockerfile updates |
Comments suppressed due to low confidence (1)
argilla-server/src/argilla_server/contexts/files.py:27
- The code later calls
json.loadandio.BytesIO, but neitherjsonnoriois imported. Please addimport jsonandimport ioto avoid NameError.
from urllib3 import HTTPResponse
jonnywireless
pushed a commit
that referenced
this pull request
Jul 31, 2025
This PR fixes issues in the Argilla integration tests and enhances document handling by: - Cleaning up CLI commands, adding reference and debug options to add_document - Expanding the Document model with from_file and updated payload serialization - Introducing LocalFileStorage for S3-like operations and updating file‐IO in the server context
JonnyTran
added a commit
that referenced
this pull request
Jul 31, 2025
This PR fixes issues in the Argilla integration tests and enhances document handling by: - Cleaning up CLI commands, adding reference and debug options to add_document - Expanding the Document model with from_file and updated payload serialization - Introducing LocalFileStorage for S3-like operations and updating file‐IO in the server context
jonnywireless
pushed a commit
that referenced
this pull request
Aug 2, 2025
This PR fixes issues in the Argilla integration tests and enhances document handling by: - Cleaning up CLI commands, adding reference and debug options to add_document - Expanding the Document model with from_file and updated payload serialization - Introducing LocalFileStorage for S3-like operations and updating file‐IO in the server context
jonnywireless
pushed a commit
that referenced
this pull request
Aug 2, 2025
This PR fixes issues in the Argilla integration tests and enhances document handling by: - Cleaning up CLI commands, adding reference and debug options to add_document - Expanding the Document model with from_file and updated payload serialization - Introducing LocalFileStorage for S3-like operations and updating file‐IO in the server context
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #54 #9