[HOLD PHP #54597] Fix: Wrong codice fiscale field name#96331
Conversation
|
@sobitneupane Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
@hoangzinh Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fd8faa2542
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Explanation of Change
Updates the correct field names for Italian tax ID:
codiceFisclaleTaxIDcodiceFiscaleTaxIDcodiceFiscaleTaxIDsignerCodiceFiscaleTaxIDThis mismatch is a real customer-facing issue the blocks them from adding their bank account.
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/636563
PROPOSAL:
Tests
Confirm business bank account currency and country, select ItalyBeneficial owner:
Do you own 25% or more of, select NoDo any individuals own 25% or more, select YesUpload additional documentation, upload all required documentsAre there more individuals who own 25% or more of, select No > ConfirmDirector:
Are you a director at, select YesUpload additional documentation, upload all required documentsOffline tests
QA Steps
Same as Tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Beneficial owner step:
Screen.Recording.2026-07-17.at.01.24.43.mov
Director step:
Screen.Recording.2026-07-17.at.01.28.07.mov