Skip to content

[No QA] Add support for consuming React Native artifacts on iOS#96293

Draft
mateuuszzzzz wants to merge 21 commits into
Expensify:mainfrom
software-mansion-labs:add-support-for-consuming-react-native-artifacts-on-ios
Draft

[No QA] Add support for consuming React Native artifacts on iOS#96293
mateuuszzzzz wants to merge 21 commits into
Expensify:mainfrom
software-mansion-labs:add-support-for-consuming-react-native-artifacts-on-ios

Conversation

@mateuuszzzzz

@mateuuszzzzz mateuuszzzzz commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Explanation of Change

This PR adds the code that lets our custom prebuilt React Native artifacts be consumed at build time, and extracts the shared resolution logic into a single TypeScript utility.

Until now, the logic that decides which published artifact version matches the local patches lived only on the Android side, in Gradle. This PR moves that common logic into a shared TypeScript utility (scripts/artifacts-utils/lib/artifactsResolver.ts, invoked via resolve-artifacts.ts). Both the Android Gradle consumer and the new iOS Ruby consumer (scripts/artifacts-utils/ios/patched_ios_artifacts.rb) now call this single resolver, so React Native version detection, GitHub Packages version lookups, and patches hash matching all live in one place instead of being duplicated per platform.

The patched artifacts utilities were also reorganized under scripts/artifacts-utils/ (a small folder structure cleanup), and compute-patches-hash.sh moved there so publishing and consumption reference the same script.

iOS consumer

The iOS Ruby helper (patched_ios_artifacts.rb) reopens ReactNativeCoreUtils to point React Native Core resolution and download at our private GitHub Packages Maven repo, matched by the patches hash. It lives in this repo because the HybridApp build (Mobile-Expensify) requires it.

Mobile-Expensify companion PR

This change is paired with Mobile-Expensify PR https://github.com/Expensify/Mobile-Expensify/pull/13918, which wires the HybridApp iOS build to consume the artifacts. That PR requires the iOS helper from this repo, builds RNFB and RNSentry as static libraries so they stay compatible with the prebuilt React Core under use_frameworks!, and adds a BUILD_RN_FROM_SOURCE toggle so developers can fall back to building React Native from source if prebuilds ever cause a problem for them.

Standalone NewDot is not supported yet

Standalone NewDot iOS does not consume the prebuilt artifacts for now. Under use_frameworks! :linkage => :static (required by Firebase) the prebuilt React Core cannot expose React_RCTAppDelegate as an importable Swift module, which the standalone Swift AppDelegate needs. HybridApp is unaffected because its AppDelegate is written in Objective C and imports that header directly with #import rather than as a Swift module. Standalone consumption is deferred.

Depends on

This PR builds on the publishing infrastructure in #88523. Until that one merges, the diff here also shows those publishing changes.

Fixed Issues

$
PROPOSAL:

MOBILE-EXPENSIFY: https://github.com/Expensify/Mobile-Expensify/pull/13918

Tests

  • Verify that app HybridApp consumes artifacts correctly. We don't support standalone NewDot for now so this can be skipped during tests.

Offline tests

QA Steps

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

@github-actions

Copy link
Copy Markdown
Contributor

⚠️ This PR is possibly changing native code and/or updating libraries, it may cause problems with HybridApp. Please check if any patch updates are required in the HybridApp repo and run an AdHoc build to verify that HybridApp will not break. Ask Contributor Plus for help if you are not sure how to handle this. ⚠️

@codecov

codecov Bot commented Jul 16, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
see 23 files with indirect coverage changes

@mateuuszzzzz

Copy link
Copy Markdown
Contributor Author

TODO: Before merging this we need to create artifacts from this branch

@mateuuszzzzz mateuuszzzzz changed the title Add support for consuming React Native artifacts on iOS [No QA] Add support for consuming React Native artifacts on iOS Jul 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant