fix: Cassandra Entity Key Serialization + Warning #370
Open
zabarn wants to merge 3 commits into
Open
Conversation
…and Valkey stores Cassandra was hardcoding serialization version 2, which silently diverged from the Python default (v3) and from the Valkey store. Both stores now resolve the version from feature_store.yaml (entity_key_serialization_version, defaulting to v3 when unset), matching Python's SerializeEntityKey behavior. Also adds a shared warnPotentialEntityKeyVersionMismatch helper (extracted into entitykeyserialization.go) that fires a single deduplicated warning when an online read returns zero data for all requested feature views — a possible indicator of a write/read version mismatch. Covered by new unit tests in both store test files. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
The test data parquet files have timestamps from April 2025. When using materialize-incremental with TTL=0 feature views, Feast defaults to a 1-year lookback window. Once the current date passed April 2026, the materialization found 0 rows to ingest, causing all Go integration tests to fail. Switch from materialize-incremental to materialize with an explicit start time of 2025-01-01 to ensure test data is always included. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
The test parquet file go/internal/test/feature_repo/driver_stats.parquet contains timestamps from 2021-2022, not 2025. The previous commit used 2025-01-01 as the start date which excluded all test data. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cassandra was hardcoding serialization version 2 at read time, which means anyone who writes to Cassandra with with entity key serialization version 3 is unable to retrieve data.
Also adds a shared warnPotentialEntityKeyVersionMismatch helper (extracted into
entitykeyserialization.go) that fires a single deduplicated warning when an online read returns zero data for all requested feature views — a possible indicator of a write/read version mismatch. Covered by new unit tests in both store test files.What this PR does / why we need it:
Which issue(s) this PR fixes:
Misc