revert: downgrade from Java 21/Hive 4 to Java 17/Hive 2.3.9 + integration test metrics#58
Draft
jamespfaulkner wants to merge 11 commits into
Draft
revert: downgrade from Java 21/Hive 4 to Java 17/Hive 2.3.9 + integration test metrics#58jamespfaulkner wants to merge 11 commits into
jamespfaulkner wants to merge 11 commits into
Conversation
…vements - Add SpringMetricsUtils and GlueSync metrics integration tests - Move integration test support classes into .support sub-package - Replace race-prone await on DummyListener with Kafka fetch metric guard + awaitOffsetCommitted via AdminClient for reliable sync - DummyListener: ArrayList → CopyOnWriteArrayList (JMM data race fix) - DroneFly: remove ApplicationContextAware and static context field to prevent Spring test context clobbering - AsyncApplicationRunner: log runner failures instead of swallowing - DroneFlyIntegrationTest: remove dead records/container infrastructure - SpringMetricsUtils.metricValue: replace manual URI string-building with UriComponentsBuilder (fixes trailing & and silent tag-skip) - Add .editorconfig, update .sdkmanrc to JDK 21 - Pin apiary.extensions.version to stable 8.2.0 (was SNAPSHOT) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This reverts commit 3be5681.
Update all three CI workflows (build, main, release) to use Amazon Corretto 17 to match the reverted Java 17 pom.xml target. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
v2 of setup-java does not support the corretto distribution; v4 does. Also upgrades checkout to v4 to avoid Node 20 deprecation warnings. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…listener dep The gluesync smoke test was written against Hive 4.x (standalone HMSHandler, 4-arg CreateTableEvent, MetricConstants from apiary 8.x) and cannot run against Hive 2.3.9. The apiary-gluesync-listener:all jar does not exist at 6.x. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Use HiveMetaStore.HMSHandler (inner class) instead of standalone HMSHandler - Drop 4th arg from CreateTableEvent constructors (3-arg Hive 2.x signature) - Pin apiary-gluesync-listener to 8.1.13 (hardcoded, all classifier) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
spotless-maven-plugin:2.4.1 bundles a google-java-format version that accesses com.sun.tools.javac.util, which is not exported by jdk.compiler on Java 17+. Skip it rather than upgrading the plugin. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
jacoco 0.8.6 from eg-oss-parent does not understand class file major version 61 (Java 17). 0.8.7+ is required; use 0.8.13 to align with the integration-tests module override. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
classes,
--add-opensJVM flags, Spring Boot 3 / Jakarta namespace changes, and aHive 4.x dependency stack that adds ongoing maintenance friction
a supported runtime
feat/integration-test-metricsDependency changes
amazoncorretto:21-al2023amazoncorretto:17-al2023What was removed
drone-fly-app/src/main/java/org/apache/hadoop/hive/metastore/.mvn/jvm.config(--add-exportsflags for google-java-format on JDK 21)--add-opensflags in SurefireargLineand Jib container configJAVA21_MIGRATION.mdjakarta.annotation.PreDestroy→ restored tojavax.annotation.PreDestroyNote for child images
Any Dockerfile that extends
drone-fly-appand overrides the JibENTRYPOINTwith--add-opensflags (e.g.egdp-docker-glue-sync-listener) can have that block removed.Leaving it in place is harmless — the flags are a no-op with Hive 2.x on Java 17.
Test plan
mvn clean verifypasses with Java 17DroneFlyIntegrationTest) passesorg/apache/hadoop/hive/metastore/shim directory in build output