test: add ApiaryGlueSync deployment smoke test#56
Merged
Conversation
Adds a @SpringBootTest that validates two things that cannot be tested inside apiary-gluesync-listener without a circular dependency: 1. The apiary-gluesync-listener:all fat jar (shaded AWS SDK + Dropwizard) loads without classpath conflicts alongside Dronefly's dependencies. 2. Spring Boot registers PrometheusMeterRegistry in Metrics.globalRegistry before ApiaryGlueSync is constructed, so MetricService does not fall back to adding a JmxMeterRegistry. Also adds the apiary-gluesync-listener:8.1.18:all and bumps kafka-metastore-listener to 8.1.18 in the integration-tests POM. Adds SerDeInfo to DroneFlyIntegrationTestUtils.buildTable() to avoid an NPE in GlueSync's HiveToGlueTransformer. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
abhimanyugupta07
approved these changes
Jun 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ApiaryGlueSyncMetricsIntegrationTest, a@SpringBootTestsmoke test that validatesapiary-gluesync-listenerdeploys correctly inside a Dronefly Spring Boot context.kafka-metastore-listenerandapiary-gluesync-listenerto8.1.18in theintegration-tests POM, adding the
:all(fat jar) classifier for gluesync.SerDeInfotoDroneFlyIntegrationTestUtils.buildTable()to avoid an NPE inGlueSync's
HiveToGlueTransformer.Why this test lives here
apiary-gluesync-listenercannot test its own behaviour inside a Dronefly Spring Bootcontext without depending on
drone-fly, which would create a circular dependency.The test guards two things specific to the Dronefly deployment model:
:allfat jar (shaded AWS SDK + Dropwizard Metrics) loadswithout conflicts alongside Dronefly's own dependencies.
PrometheusMeterRegistryinMetrics.globalRegistrybeforeApiaryGlueSyncis constructed. If that orderingwere wrong,
ApiaryGlueSync.MetricServicesilently falls back to adding aJmxMeterRegistryand metrics never reach Prometheus.Test plan
mvn -pl drone-fly-integration-tests -Dtest=ApiaryGlueSyncMetricsIntegrationTest testpasses locally🤖 Generated with Claude Code