Skip to content

fix: use equalsIgnoreCase in isTableRename to match HMS behaviour #138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jamespfaulkner merged 1 commit into from
Jun 26, 2026
Merged

fix: use equalsIgnoreCase in isTableRename to match HMS behaviour #138

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...er/src/main/java/com/expediagroup/apiary/extensions/gluesync/listener/ApiaryGlueSync.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -302,7 +302,7 @@ private void doRenameOperation(Table oldTable, Table newTable) {
}

private boolean isTableRename(Table oldTable, Table newTable) {
return !oldTable.getTableName().equals(newTable.getTableName());
return !oldTable.getTableName().equalsIgnoreCase(newTable.getTableName());
}

@Override
Expand Down
24 changes: 24 additions & 0 deletions ...rc/test/java/com/expediagroup/apiary/extensions/gluesync/listener/ApiaryGlueSyncTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@
import static org.mockito.ArgumentMatchers.argThat;
import static org.mockito.ArgumentMatchers.eq;
import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.never;
import static org.mockito.Mockito.times;
import static org.mockito.Mockito.verify;
import static org.mockito.Mockito.verifyNoMoreInteractions;
Expand Down Expand Up @@ -499,6 +500,29 @@ public void onAlterHiveTable_RenameTable() throws MetaException {
assertThat(toList(createTableRequest.getTableInput().getStorageDescriptor().getColumns()), is(asList(colNames)));
}

@Test
public void onAlterHiveTable_CaseOnlyRenameSkipsRenameOperation() throws MetaException {
AlterTableEvent event = mock(AlterTableEvent.class);
when(event.getStatus()).thenReturn(true);

Table oldTable = simpleHiveTable(simpleSchema(), simplePartitioning());
oldTable.setTableName("some_table");
when(event.getOldTable()).thenReturn(oldTable);

Table newTable = simpleHiveTable(simpleSchema(), simplePartitioning());
newTable.setTableName("Some_Table");
when(event.getNewTable()).thenReturn(newTable);

glueSync.onAlterTable(event);

// case-only difference must not trigger the rename path (create + copy + delete)
verify(glueClient, never()).createTable(any());
verify(glueClient, never()).deleteTable(any());
verify(glueClient, never()).batchCreatePartition(any());
// normal update path must be followed instead
verify(glueClient).updateTable(any());
}

@Test
public void onCreateUnpartitionedHiveTable() throws MetaException {
CreateTableEvent event = mock(CreateTableEvent.class);
Expand Down
Loading