test: add ApiaryGlueSync coverage baseline#136
Merged
Conversation
Add tests for previously uncovered paths in all 8 event handlers: recovery paths (AlreadyExistsException/EntityNotFoundException), onDropTable (happy path and not-found), onDropPartition (happy path), onAddPartition (happy path), onAlterPartition (happy path and not-found recovery), onAlterIcebergTable_RenameTableSkipsRenameOperation, failure metric recording, throwExceptions=true rethrow, and a single test covering getStatus()==false across all handlers. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
javsanbel2
approved these changes
Jun 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ApiaryGlueSyncevent handlers that was previously missing:onCreateDatabase(already-exists path),onCreateTable(already-exists path),onAlterTable(entity-not-found path),onAlterPartition,onAddPartition(already-exists path),onDropTable,onDropPartition, and a single test asserting all handlers areno-ops when
event.getStatus() == falsefeat/EGDL-8244/improved-observabilitybranch to compile againstmain—MetricService.recordEvent()does not exist here, so those verificationsare omitted;
incrementCounterand Glue API call verifications are retainedfeat/EGDL-8244/improved-observabilityso the diff on that PR shows only production code changes alongside their corresponding new testsTest plan
mvn test -pl hive-event-listeners/apiary-gluesync-listenerpasses on this branchrecordEventreferences remain in the test file (that method does not exist onmain)feat/EGDL-8244/improved-observability🤖 Generated with Claude Code