Skip to content

build: bump Final2x-core to v4.0.0#682

Merged
Tohrusky merged 2 commits into
EutropicAI:mainfrom
TohruskyDev:main
Sep 27, 2025
Merged

build: bump Final2x-core to v4.0.0#682
Tohrusky merged 2 commits into
EutropicAI:mainfrom
TohruskyDev:main

Conversation

@Tohrusky

Copy link
Copy Markdown
Member

No description provided.

@gemini-code-assist

Copy link
Copy Markdown

Summary of Changes

Hello @Tohrusky, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on upgrading the core Final2x-core component to its v4.0.0 release. This involves updating the direct download URLs for the core binaries and performing a general cleanup of the README.md to remove outdated information and streamline installation instructions, ensuring the documentation accurately reflects the current state of the project's dependencies and recommendations.

Highlights

  • Core Dependency Update: The Final2x-core dependency has been updated to version v4.0.0, with corresponding changes to its download links.
  • Documentation Cleanup: Outdated news entries and specific references to previous technologies (ccrestoration, PyTorch, ncnn) have been removed from the README.md.
  • Installation Instructions Refinement: The Windows installation section in README.md has been simplified to generally mention package managers like winget and scoop, with a note about potential version discrepancies.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request bumps the Final2x-core dependency to v4.0.0. The changes correctly update the download links in the build script and adjust the README file to reflect this update by removing outdated news and references. I have one suggestion to improve the wording in the README for better clarity and professionalism.

Comment thread README.md Outdated
```bash
winget install Final2x
```
Btw, you can use some package mananger to install and upgrade such as winget or scoop. Notice that they may not be the latest version.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This sentence could be improved for clarity and professionalism. "Btw" is quite informal for documentation, and there is a typo in "mananger". I suggest rephrasing the sentence to be more direct and professional.

Suggested change
Btw, you can use some package mananger to install and upgrade such as winget or scoop. Notice that they may not be the latest version.
You can also use a package manager like winget or scoop to install and upgrade. Please note that the versions available through package managers may not always be the latest.

@Tohrusky Tohrusky merged commit fe15d70 into EutropicAI:main Sep 27, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant