1306 fix#1307
Merged
Merged
Conversation
…ed regardless of plugin availability or not, thanks new gcc for showing it
…e bug report and fix Closes: Ettercap#1306
…len is greater than the offset
…minator, due to string assignment. Using uint8_t looks a correct fix, since this is a mac address going into that data structure, avoiding useless casts
… instead ck_assert_msg, according to the tutorial of check library looks the correct implementation
warning: initializer-string for array of ‘char’ truncates NUL terminator but destination lacks ‘nonstring’ attribute (17 chars into 16 available) [-Wunterminated-string-initialization] 56 | static char itoa16[16] = "0123456789abcdef";
warning: the comparison will always evaluate as ‘false’ for the pointer operand in ‘ptr + (sizetype)i’ must not be NULL [-Waddress] 170 | if (ptr+i == NULL)
warning: ‘calloc’ sizes specified with ‘sizeof’ in the earlier argument and not in the later argument [-Wcalloc-transposed-args] 180 | SAFE_CALLOC(s->data, sizeof(ssh_session_data), 1);
warning: initializer-string for array of ‘char’ truncates NUL terminator but destination lacks ‘nonstring’ attribute (7 chars into 6 available) [-Wunterminated-string-initialization]
warning: ‘CURLOPT_PROTOCOLS’ is deprecated: since 7.85.0. Use CURLOPT_PROTOCOLS_STR [-Wdeprecated-declarations] 890 | curl_easy_setopt(connection->handle, CURLOPT_PROTOCOLS, (long) CURLPROTO_HTTP |
Member
|
Looks good to me |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.