fix crash when wait_barrier_slow is called with a nil barrier#827
Open
ratchetfreak wants to merge 1 commit into
Open
fix crash when wait_barrier_slow is called with a nil barrier#827ratchetfreak wants to merge 1 commit into
ratchetfreak wants to merge 1 commit into
Conversation
other backends will guard against that before calling underlying api.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a crash on win7 (and any platform which uses slow barriers) because some threads call barrier_wait with only 1 lane and no allocated barrier.
Other backends will guard against that before calling underlying api. I did the same here.