Review of pthread_* return values#793
Open
mlechon wants to merge 121 commits into
Open
Conversation
kill on when torture crashes
…ction for external libraries
… or module, or unit, and use in debug info resolution matching path; automatically prefer selected thread voff's unit
number for error reports and allow scripts without header)
mode may cause use-after-free
…tyle path for local symbol server cache
…l/line-from-vaddr commands
NikitaSmith057
force-pushed
the
dev
branch
3 times, most recently
from
95a5325 to
449c9f1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(Hi and thanks for the linux port! Feel free to close/disregard this PR without comment.)
There are some checks of
pthread_*return values that don't look right, if we go by the manual pages. In general, these functions return0when successful and an error code (not necessarily-1) on failure. Also,pthread_mutex_initalways returns0, so there's no point in checking it.