Fix CDN invalid manifest cache recovery#2197
Open
cursor[bot] wants to merge 1 commit into
Open
Conversation
Co-authored-by: Sharjeel Yunus <sharjeelyunus@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
git diff --check HEAD~1..HEADdart/flutterexecutables are not available on PATH in this environment.Note
Medium Risk
Changes CDN manifest cache recovery and state-reset behavior, which affects app startup and refresh logic if a persisted cache entry is corrupted or stale.
Overview
Fixes corrupted CDN manifest cache recovery by clearing all in-memory provider state (artifact cache, mappings, config, ETag/
_lastUpdatedAt, pending-update flag) and persistedSharedPreferencesentry when cached manifest JSON cannot be decoded.Refactors runtime secret cleanup into
_clearRuntimeSecrets()and ensures it is invoked on manifest rebuilds and cache clears so secrets/env entries don’t linger across refreshes. Adds test-only hooks to load cached state and assert freshness metadata, plus a regression test covering invalid persisted cache invalidation.Reviewed by Cursor Bugbot for commit 00ec9cc. Configure here.