Skip to content

refactor: migrate GeoInfo points filed into GeoJSON data scheme via geo_json field#1536

Merged
beesaferoot merged 4 commits into
mainfrom
refactor/geographical-info-model-#1035
Jun 30, 2026
Merged

refactor: migrate GeoInfo points filed into GeoJSON data scheme via geo_json field#1536
beesaferoot merged 4 commits into
mainfrom
refactor/geographical-info-model-#1035

Conversation

@beesaferoot

Copy link
Copy Markdown
Contributor

Ths PR carries out a large but crucial refactor before landing MPM v1.0. This continues a string of refactors that replaces changes existing location data into on consistent standard GeoJSON format.

Closes #1035

Brief summary of the change made

Are there any other side effects of this change that we should be aware of?

Describe how you tested your changes?

Pull Request checklist

Please confirm you have completed any of the necessary steps below.

  • Meaningful Pull Request title and description
  • Changes tested as described above
  • Added appropriate documentation for the change.
  • Created GitHub issues for any relevant followup/future enhancements if appropriate.

@beesaferoot beesaferoot requested a review from dmohns June 27, 2026 12:27

@dmohns dmohns left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice!! Looking forward to it. Few comments

Comment thread src/backend/app/Models/GeographicalInformation.php Outdated
Comment thread src/backend/app/Models/GeographicalInformation.php Outdated
@beesaferoot beesaferoot force-pushed the refactor/geographical-info-model-#1035 branch from ee4d25d to 4539bf2 Compare June 29, 2026 22:49
@beesaferoot beesaferoot requested a review from dmohns June 30, 2026 09:46
@dmohns

dmohns commented Jun 30, 2026

Copy link
Copy Markdown
Member

Nice!!! Last question... can you expand why you chose jmikola/geojson? It seems a bit inactive, last commit 3 years ago, only tested against PHP 8.2. Compared to the more active brick/geo ?

@beesaferoot beesaferoot force-pushed the refactor/geographical-info-model-#1035 branch from 4e988f5 to 96b86df Compare June 30, 2026 09:49
@beesaferoot

Copy link
Copy Markdown
Contributor Author

Nice!!! Last question... can you expand why you chose jmikola/geojson? It seems a bit inactive, last commit 3 years ago, only tested against PHP 8.2. Compared to the more active brick/geo ?

brick/geo comes with a ton of features we don't utilize more than constructing a GeoJSON object i.e performing operations on these objects. While jmikola/geojson implements the GeoJSON format specification and doesn't add anything else; which I think is just right for our use case.

I didn't think we needed a dependency that we don't use 99% of its features.

@beesaferoot beesaferoot merged commit 3ecb4cc into main Jun 30, 2026
17 checks passed
@beesaferoot beesaferoot deleted the refactor/geographical-info-model-#1035 branch June 30, 2026 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Request]: Convert GeographicalInformation point to GeoJSON

2 participants