fix: resubmit #198/#200/#201/#202 with correct commit authorship#364
Open
uche001-dev wants to merge 1 commit into
Open
fix: resubmit #198/#200/#201/#202 with correct commit authorship#364uche001-dev wants to merge 1 commit into
uche001-dev wants to merge 1 commit into
Conversation
Emmy123222#200 — initialize() now returns Result<(), ContractError> and returns Err(ContractError::AlreadyInitialized) on re-init instead of panicking. Adds test_double_initialize_returns_error to verify the error path. Emmy123222#202 — send_tip event tuple now explicitly clones `from` before moving it into the (tip, from, to) topic tuple, eliminating the potential borrow/move conflict. Adds test_send_tip_emits_event_with_from_and_to. Emmy123222#201 — All TipTotal/TipCount/TipRecord entries already used persistent storage. Adds test_tip_totals_are_per_recipient_persistent to confirm per-recipient key isolation. Emmy123222#198 — isFreighterInstalled, hasSiteAccess, and signTransactionWithWallet now return safe defaults when typeof window === "undefined", preventing a ReferenceError during Next.js SSR. Adds wallet-ssr.test.ts with 3 node-environment tests verifying the SSR branches. closes Emmy123222#198 closes Emmy123222#200 closes Emmy123222#201 closes Emmy123222#202
|
@uche001-dev is attempting to deploy a commit to the Emmanuel's projects Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
PR #362 (merged 2026-06-02) was merged with an incorrect commit author/committer (
David Ejereinstead ofNwokedi Uche). This was caused by a git config leak during the commit.This PR resubmits the exact same changes (identical tree SHA
42414fc) with the correct authorship:Nwokedi Uche <lifegoeshardsometimes@gmail.com>.Request
Please:
git revert -m 1 <merge-sha>) or use GitHub's revert buttonThe code changes are identical — only the commit metadata is corrected.
closes #198
closes #200
closes #201
closes #202