Skip to content

feat: Added admin attribute functionalities#52

Merged
jansentjeu merged 13 commits into
developfrom
feat/TW-112-attribute-landing-filters
Apr 10, 2026
Merged

feat: Added admin attribute functionalities#52
jansentjeu merged 13 commits into
developfrom
feat/TW-112-attribute-landing-filters

Conversation

@jansentjeu

@jansentjeu jansentjeu commented Mar 29, 2026

Copy link
Copy Markdown
Collaborator

This PR adds support in the Magento admin for assigning attributes to attribute landing pages based on data from Tweakwise. It introduces the option to use the Tweakwise backend API, allowing selection of attributes that are not part of the filter template.

TODO: This MR needs also #54 in new release

Testscenario 1:

  1. Make sure the following setting is empty: Stores -> Configuration -> Catalog -> Tweakwise -> Attribute Landing Pages -> Backend API Access Token
  2. Go to Content -> Attribute landing pages -> Manage pages
  3. Add a new page and check if attribute functionality works the same as before
  4. Edit an existing page and check if attribute functionality works the same as before

Testscenario 2:

  1. Make sure your backend API access toke is set in: Stores -> Configuration -> Catalog -> Tweakwise -> Attribute Landing Pages -> Backend API Access Token
  2. Go to Content -> Attribute landing pages -> Manage pages
  3. Add a new page and check if not only attributes are showed which are available in your filter template
  4. Edit an existing page and check if not only attributes are showed which are available in your filter template

@ahuininga-orisha ahuininga-orisha left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When you add an custom attribute and value as an filter attribute, and you save the page. And open it again, the custom attribute and custom value is not displayed in the text field.

Comment thread src/Controller/Adminhtml/Ajax/AbstractFacetController.php
@jansentjeu jansentjeu changed the base branch from beta to develop April 3, 2026 09:57
@jansentjeu

Copy link
Copy Markdown
Collaborator Author

When you add an custom attribute and value as an filter attribute, and you save the page. And open it again, the custom attribute and custom value is not displayed in the text field.

@ahuininga-orisha Fixed this issue. You have to pull newest changes from all modules.

Comment thread src/Model/Client/Response/FacetAttributesResponse.php Outdated
@jansentjeu jansentjeu merged commit 0d2f86c into develop Apr 10, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants