Repository navigation
ci: run CI on release-please PRs - #53
Merged
Merged
Conversation
release-please pushes its release branch with GITHUB_TOKEN, which starts no workflow, so the release PR never got the required check / check. Pin the shared release-please workflow to 5b1f535, which dispatches ci.yml on the release branch (ci-workflow: ci.yml), grant it actions: write, and let ci.yml run on workflow_dispatch. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
c1e67a6 (actions#11) dispatches CI over the action_required pull_request run that a github.token push leaves on the release branch head; 5b1f535 counted that run and skipped the dispatch. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
dec791a (actions#12) warns instead of failing the release-please job when GitHub refuses the CI dispatch, e.g. on a release branch cut before ci.yml accepted workflow_dispatch. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release-please opens and updates its release PR with
GITHUB_TOKEN, which starts no workflow, so the release PR never got the requiredcheck / checkand could not merge without a bypass.ci.yml: acceptworkflow_dispatch.release-please.yml: pin the shared workflow to Emerging-Patterns/actions@5b1f535 (actions#10), grantactions: write(workflow and job), and passci-workflow: ci.yml. After release-please runs, it dispatchesci.ymlon each open release PR head that has no CI run yet. The dispatched run'scheckjob callsnix-flake-check.yml(jobcheck), so it reports ascheck / checkon the release PR head, matching the ruleset.🤖 Generated with Claude Code