Skip to content

Support vector grid functions in GF3D2#388

Merged
eschnett merged 6 commits into
mainfrom
eschnett/vgf
Jun 26, 2026
Merged

Support vector grid functions in GF3D2#388
eschnett merged 6 commits into
mainfrom
eschnett/vgf

Conversation

@eschnett

Copy link
Copy Markdown
Collaborator

No description provided.

@rhaas80 rhaas80 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. So the functionality in Arith that supports this:

Arith::masko_loadu(mask, &(*this)(I, n), other)

already existed?

@eschnett

Copy link
Copy Markdown
Collaborator Author

No, Arith is not involved. This calls &(*this)(I, n), which calls the constructor of GF3D2 with I, n (which I added), takes the address, and passes it to loadu. All new functionality is in loop.hxx.

@eschnett eschnett merged commit 7f6671e into main Jun 26, 2026
17 of 32 checks passed
@eschnett eschnett deleted the eschnett/vgf branch June 26, 2026 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants