AsterSeeds: add code to perturb neutron star#145
Open
jaykalinani wants to merge 7 commits into
Open
Conversation
acwen11
reviewed
Jun 17, 2026
| } "Set initial entropy" | ||
| if (set_entropy_postinitial && !CCTK_Equals(evolution_eos, "Tabulated3d")) { | ||
| if (set_temperature_postinitial) { | ||
| SCHEDULE SetEntropy IN HydroBaseX_PostInitial AFTER SetTemp |
Collaborator
There was a problem hiding this comment.
Could this not be simplified to just say SCHEDULE SetEntropy IN HydroBaseX_PostInitial AFTER SetTemp AFTER SetYe?
| WRITES: HydroBaseX::rho(everywhere) HydroBaseX::eps(everywhere) HydroBaseX::press(everywhere) HydroBaseX::temperature(everywhere) HydroBaseX::entropy(everywhere) | ||
| } "Apply neutron-star pressure or density perturbation after hydro initial data" | ||
| } else { | ||
| SCHEDULE AsterSeeds_PerturbNS IN HydroBaseX_PostInitial |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Different ways to perturb initial data of a neutron star are added. Code for external dipolar field for single NS is added as well. Minor changes to function names as well as schedule.
Scripts for CompOSE EOS table are also added.
CompOSE tables also have a bug in the spelling. EOSX now includes the spelling error for consistency.