fix(skills): harden plugin root resolution across install modes#95
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the /understand skill’s pre-flight instructions to resolve the Understand Anything plugin root in a symlink-safe way (targeting Pi installs where skills are exposed via symlinks), ensuring pnpm commands run in the correct workspace directory.
Changes:
- Adds symlink-safe resolution for the skill path via
realpath/readlink -fto derive a self-relative plugin root. - Prefers the universal plugin-root symlink
~/.understand-anything-pluginwhen present, with fallback to the resolved real checkout path. - Validates candidates by checking for
package.jsonandpnpm-workspace.yamlbefore running build steps.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Thanks for the contribution! |
|
@codex review this |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6a071b5abd
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review this |
|
Codex Review: Didn't find any major issues. Another round soon, please! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Summary
This PR improves plugin root resolution robustness for
/understandand/understand-dashboardacross different installation modes and hosts.What changed
CLAUDE_PLUGIN_ROOTas the first plugin-root candidate (runtime-provided root should win)~/.understand-anything-plugin~/.agents/skills/...real path~/.copilot/skills/...real path~/.codex/understand-anything/understand-anything-plugin~/.opencode/understand-anything/understand-anything-plugin~/.pi/understand-anything/understand-anything-plugin~/understand-anything/understand-anything-pluginunderstandandunderstand-dashboardWhy
/understandcould fail with “Cannot find the understand-anything plugin root” in valid installs where:~/.understand-anything-pluginis absent, and~/.agents/skills/...is unavailable/unresolvable, whileCLAUDE_PLUGIN_ROOT).This could also cause inconsistent behavior between skills (
/understandvs/understand-dashboard) and potential version mismatch when multiple roots exist.Impact
Commits in this PR branch
a2071fbfix(pi): resolve understand plugin root via symlink-safe logic6a071b5chore(pi): improve plugin root error messaged9250d7fix(skills): harden plugin root resolution across install modes