fix(skills): force explicit UTF-8 on locale-default Python file reads#524
Merged
Lum1104 merged 1 commit intoJul 5, 2026
Merged
Conversation
The domain-context scanner and a merge test read files via Path.read_text(errors="replace") with no explicit encoding. pathlib's read_text/write_text fall back to locale.getpreferredencoding(False) when encoding is omitted; on Windows, absent Python UTF-8 mode (PEP 540), that is the ANSI codepage (cp1252 / cp936 / cp932), not UTF-8. extract-domain-context.py (lines 126, 211, 270, 315, 418) reads source files, .gitignore, and metadata, then writes domain-context.json. On Windows the reads decode UTF-8 source against the wrong codepage, silently mojibaking CJK comments, accented identifiers, em-dashes, and translated README text into the context fed to the domain-analyzer agent. errors="replace" does not catch this: legacy codepages decode nearly every byte to a *wrong* character rather than raising, so corruption is silent. test_merge_batch_graphs.py (lines 986, 1105) reads assembled-graph.json back for assertions; merge-batch-graphs.py writes it with ensure_ascii=False, so it can contain raw non-ASCII that the unencoded read would mojibake on Windows. Both now pass encoding="utf-8", matching every other Python script in the repo (merge-batch-graphs.py, merge-subdomain-graphs.py, parse-knowledge-base.py, merge-knowledge-graph.py). No behavior change on Linux/macOS, where the locale default is already UTF-8. Relates to the Windows-compat reports Egonex-AI#262, Egonex-AI#340. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Collaborator
|
@codex review this |
|
Codex Review: Didn't find any major issues. What shall we delve into next? Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Two Python files read with no explicit
encoding=.pathlib'sread_text/write_textfall back tolocale.getpreferredencoding(False)when none is given. On Windows — absent Python UTF-8 mode (PEP 540) — that's the ANSI codepage (cp1252/cp936/cp932), not UTF-8.skills/understand-domain/extract-domain-context.py(lines 126, 211, 270, 315, 418) reads source files,.gitignore, and metadata, then writesdomain-context.json. On Windows the reads decode UTF-8 source against the wrong codepage and silently corrupt the context that thedomain-analyzeragent consumes — CJK comments, accented identifiers, em-dashes, the translated README text pulled in at line 332.errors="replace"does not catch this: legacy codepages decode almost every byte to some (wrong) character instead of raising, so there's noUnicodeDecodeErrorand no replacement char — just silent mojibake.Reproduction
A UTF-8 source file with a CJK comment, read the way Windows would:
Both alternate reads used
errors="replace"— neither raised, both are silently wrong.tests/skill/understand/test_merge_batch_graphs.py(lines 986, 1105) readsassembled-graph.jsonback for assertions.merge-batch-graphs.pywrites it withensure_ascii=False, so it can contain raw non-ASCII that the unencoded read would mojibake on Windows, failing the test there.Fix
Pass
encoding="utf-8"to the affected reads/write. This matches the convention already used in every other Python script in the repo (merge-batch-graphs.py,merge-subdomain-graphs.py,parse-knowledge-base.py,merge-knowledge-graph.py). No behavior change on Linux/macOS, where the locale default is already UTF-8.Scope
7 lines across 2 files. Relates to the Windows-compat reports #262 and #340.