feat: add --exclude CLI flag to /understand for user-defined ignore p…#373
feat: add --exclude CLI flag to /understand for user-defined ignore p…#373yiziff wants to merge 2 commits into
Conversation
…atterns - createIgnoreFilter() now accepts optional extraPatterns array (Layer 4, highest priority) - scan-project.mjs parses --exclude from CLI args and passes patterns through - project-scanner.md documents --exclude flag usage - SKILL.md wires --exclude into Phase 0/1 and updates argument-hint - 5 new test cases covering CLI priority, ! negation, and .understandignore interaction Related: Egonex-AI#76
|
Reviewed the full diff, checked out the branch, and ran the tests. Verdict: correct and well-scoped. The feature does what it claims. What I verified:
One thing worth a doc note (not blocking):
Otherwise this is good to merge. |
Addressed reviewer feedback: added a note in SKILL.md to clarify that newly added --exclude patterns require a --full scan to take effect.
|
Thanks for the thorough review and testing, @tirth8205 ! I completely agree with the incremental scan behavior. I've just pushed a commit to update SKILL.md with that exact warning about needing --full to apply new exclusions. Let me know if it looks good to go! |
…atterns
Related: #76
Summary
Linked issue(s)
How I tested this
pnpm lintpnpm --filter @understand-anything/core testpnpm testVersioning