Repository navigation
feat: 支持永久换课、软件清单上报与插件管理服务 - #22
Conversation
![codefactor-io[bot]](https://avatars.githubusercontent.com/in/25603?s=60&v=4){kind=small}
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ef013ce39b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Co-authored-by: codefactor-io[bot] <47775046+codefactor-io[bot]@users.noreply.github.com>
Co-authored-by: codefactor-io[bot] <47775046+codefactor-io[bot]@users.noreply.github.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0ac4bbe829
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| await DownloadJsonIfPresentAsync<ManagementPolicy>( | ||
| manifest.PolicySource.Value, | ||
| GetStaticString(managementType, "ManagementPolicyPath"), | ||
| settings, | ||
| clientId, | ||
| ct); | ||
| await DownloadJsonIfPresentAsync<ManagementCredentialConfig>( | ||
| manifest.CredentialSource.Value, |
There was a problem hiding this comment.
When a valid management manifest omits its optional policy or credential source, accessing PolicySource.Value or CredentialSource.Value throws before DownloadJsonIfPresentAsync can handle the missing value. This makes joining any serverless/management deployment that does not publish both auxiliary files fail with an internal error; pass the optional source itself (or check it before accessing Value) so the helper can skip absent files.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bb6edf3e22
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| /// <summary>把换课写入 ClassIsland 源课表（本周及以后每周生效），而不是只写到当天临时课表层。</summary> | ||
| public const string ScheduleChangePermanent = "schedule.change-permanent"; |
There was a problem hiding this comment.
The new schedule.change-permanent capability is declared here but is never included in Current and Required always maps ChangeSchedule to the ordinary schedule.change capability. As a result, a client can send permanent: true to an older plugin that advertises only the existing schedule-change capability; the older model silently deserializes the unknown field as false and applies a temporary overlay, so the user receives a successful response while the requested permanent change is lost. Add capability negotiation/validation for permanent requests (and advertise it for supporting plugins) before forwarding.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2de162a063
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
1 participant
变更说明
关联变更
检查清单
dotnet build RemoteCI.slnx -c Release与dotnet test RemoteCI.slnx -c Release./gradlew :app:assembleDebug :app:testDebugUnitTest