Repository navigation
Feature/multi class - #21
Conversation
- 服务端新增班级实体与授权镜像，登录支持班级维度权限与首登设密挑战 - 插件按班级接收授权镜像并展示归属班级名称 - 移动端新增班级选择器、班级切换与按 classId 过滤的扩展策略接口
![codefactor-io[bot]](https://avatars.githubusercontent.com/in/25603?s=60&v=4){kind=small}
Co-authored-by: codefactor-io[bot] <47775046+codefactor-io[bot]@users.noreply.github.com>
Co-authored-by: codefactor-io[bot] <47775046+codefactor-io[bot]@users.noreply.github.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bdda448904
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (request.Operation.Trim().Equals("delete", StringComparison.OrdinalIgnoreCase)) | ||
| await peers.DisconnectPluginClassAsync([.. request.ClassIds.Distinct()], ct); |
There was a problem hiding this comment.
When a delete batch includes groupIds, ClassroomService.BatchAsync expands the group into its member class IDs and successfully deletes those classes, but this cleanup only disconnects request.ClassIds. Any plugin belonging to a class reached only through the group remains connected with its in-memory credential until a later refresh, so it can continue sending state/events after deletion and the endpoint does not fulfill its immediate-disconnect behavior. Use the successful result IDs (or the fully resolved target list) when disconnecting.
Useful? React with 👍 / 👎.
| new BackupSettingsSnapshot(backup.Enabled, backup.Cadence, backup.TimeOfDay, backup.DayOfWeek, backup.MaxBackups), | ||
| state.GetLatestSchedule(), extensionPolicies, extensionPreferences); | ||
| state.GetLatestSchedule(Classroom.DefaultId), extensionPolicies, extensionPreferences, | ||
| classrooms, memberships, groups); |
There was a problem hiding this comment.
The new multi-class state store keeps schedules per class, but configuration capture serializes only state.GetLatestSchedule(Classroom.DefaultId) and restore writes that single schedule back to the default class. A backup/restore after using any other class therefore silently loses that class's latest schedule, even though the rest of its classroom and membership configuration is restored.
Useful? React with 👍 / 👎.
1 participant
变更说明
关联变更
检查清单
dotnet build RemoteCI.slnx -c Release与dotnet test RemoteCI.slnx -c Release./gradlew :app:assembleDebug :app:testDebugUnitTest