Skip to content

Fix compilation warnings #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Butakus merged 7 commits into from
Oct 17, 2025
Merged

Fix compilation warnings #16

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
7399fb4
README.md
fmrico Oct 12, 2025
55b6758
Add Jazzy
fmrico Oct 17, 2025
1f00e9f
Merge kilted into rolling
Butakus Oct 17, 2025
a309c4e
Merge pull request #13 from Butakus/rolling
Butakus Oct 17, 2025
3f4e2c4
Fix compilation warnings
Butakus Oct 17, 2025
8b9e078
Merge pull request #15 from Butakus/rolling
Butakus Oct 17, 2025
bd2171d
Merge rolling into kilted. Fix compilation warnings
Butakus Oct 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions controllers/easynav_serest_controller/src/easynav_serest_controller/SerestController.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -476,13 +476,13 @@ SerestController::apply_corner_guard(
bool
SerestController::should_turn_in_place(
bool allow_reverse, double e_theta, double e_theta_goal,
double dist_to_end, double turn_in_place_thr) const
double dist_to_end, [[maybe_unused]] double turn_in_place_thr) const
{
// Mantenemos compatibilidad con la firma, pero ignoramos turn_in_place_thr
// y usamos dos umbrales internos sin exponer parámetros.
const double PI = 3.14159265358979323846;
const double thr_enter = 60.0 * PI / 180.0; // entra a girar si |e_theta| > 60°
const double thr_exit = 35.0 * PI / 180.0; // sale de girar si |e_theta| < 35°
// const double thr_exit = 35.0 * PI / 180.0; // sale de girar si |e_theta| < 35°

// No permitimos “atajo” marcha atrás en esta decisión: si no permites reverse,
// el criterio es más estricto.
Expand Down
2 changes: 1 addition & 1 deletion localizers/easynav_costmap_localizer/include/easynav_costmap_localizer/AMCLLocalizer.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
#include "nav_msgs/msg/odometry.hpp"

#include "tf2/LinearMath/Transform.hpp"
#include "tf2_ros/transform_broadcaster.h"
#include "tf2_ros/transform_broadcaster.hpp"

#include "easynav_core/LocalizerMethodBase.hpp"

Expand Down
2 changes: 1 addition & 1 deletion localizers/easynav_gps_localizer/include/easynav_gps_localizer/GpsLocalizer.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
#include "sensor_msgs/msg/nav_sat_fix.hpp"
#include "easynav_core/LocalizerMethodBase.hpp"
#include "geometry_msgs/msg/transform_stamped.hpp"
#include "tf2_ros/static_transform_broadcaster.h"
#include "tf2_ros/static_transform_broadcaster.hpp"
#include "sensor_msgs/msg/imu.hpp"
#include "tf2/LinearMath/Quaternion.hpp"
#include "tf2/LinearMath/Matrix3x3.hpp"
Expand Down
2 changes: 1 addition & 1 deletion localizers/easynav_gps_localizer/src/easynav_gps_localizer/GpsLocalizer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ void GpsLocalizer::imu_callback(const sensor_msgs::msg::Imu::SharedPtr msg)
}


void GpsLocalizer::update_rt(NavState & nav_state)
void GpsLocalizer::update_rt([[maybe_unused]] NavState & nav_state)
{
}

Expand Down
2 changes: 1 addition & 1 deletion localizers/easynav_navmap_localizer/include/easynav_navmap_localizer/AMCLLocalizer.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
#include "nav_msgs/msg/odometry.hpp"

#include "tf2/LinearMath/Transform.hpp"
#include "tf2_ros/transform_broadcaster.h"
#include "tf2_ros/transform_broadcaster.hpp"

#include "navmap_core/NavMap.hpp"

Expand Down
Loading