Skip to content

Back to 25 million#695

Closed
TheJeran wants to merge 4 commits into
mainfrom
jp/samplePoints
Closed

Back to 25 million#695
TheJeran wants to merge 4 commits into
mainfrom
jp/samplePoints

Conversation

@TheJeran

@TheJeran TheJeran commented Jul 20, 2026

Copy link
Copy Markdown
Collaborator

Going back to 25 million

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request corrects a mathematical typo in PointCloud.tsx by changing 2e31 to 2**31 for the maxPointsPerDraw constant. The reviewer noted that while this fix is mathematically correct, setting the limit to approximately 2.1 billion effectively disables the chunking loop, potentially causing GPU timeouts or browser freezes when rendering large datasets. They recommended reducing the limit to a practical value, such as 1 million points, to ensure chunking remains effective.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread src/components/plots/PointCloud.tsx Outdated
@TheJeran TheJeran changed the title e --> exponent Back to 25 million Jul 20, 2026
@TheJeran TheJeran closed this Jul 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant