Repository navigation
Widen rDate log formats that overflow to asterisks - #457
Merged
Merged
Conversation
yyyymmdd.fraction dates need at least 14 characters, so f13.5/f13.6 always printed asterisks. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
anton-seaice
commented
Oct 27, 2026
| if (limit) then | ||
| if (strm%mainproc) then | ||
| write(strm%logunit,'(2a,2(f13.5,2x))') subname,& | ||
| write(strm%logunit,'(2a,2(f20.4,2x))') subname,& |
Contributor
Author
There was a problem hiding this comment.
The change makes it consistent with other logging in this file, e.g.
anton-seaice
marked this pull request as ready for review
October 27, 2026 04:05
Contributor
Author
|
ready to go @mvertens @billsacks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Widen three log format statements that print
yyyymmdd + fraction of daydates. An 8-digit date with 5 (or 6) decimals needs 14 (or 15) characters, sof13.5/f13.6always overflow and the values print as asterisks. This made thelimitabort inshr_stream_findBoundshard to diagnose, as the dates in the error message were unreadable.streams/dshr_stream_mod.F90: the twoERROR: limit on and rDateIn >= rDategvdwrites,f13.5->f20.4(matching the existingrDateIn lt rDatelvderror and therDateIn,rDatelvd,rDategvddebug write in the same routine)streams/dshr_strdata_mod.F90: therdateLB,rdateM,rdateUBwrite inshr_strdata_readLBUB,f13.6->f20.6Example output before:
After:
Testing performed (e.g. aux_cdeps, CESM prealpha, etc): Compiled the old and new write statements standalone with ifx and printed representative dates (output above). Not run through aux_cdeps.
🤖 Generated with Claude Code