Repository navigation
datm clmncep: set Faxa_swdn from whichever shortwave stream is present (fixes #425) - #456
Closed
asystemoffields wants to merge 1 commit into
Closed
asystemoffields wants to merge 1 commit into
asystemoffields wants to merge 1 commit into
Conversation
datm_datamode_clmncep_advance copied strm_Faxa_swdn into Faxa_swdn unconditionally, so a stream configuration that provides direct and diffuse shortwave (Faxa_swdndr and Faxa_swdndf) instead of the total dereferenced an unassociated pointer. Set Faxa_swdn inside the shortwave block instead: the sum of the direct and diffuse streams when those are present, otherwise the total stream. This is the change agreed in ESCOMP#425. Resolves ESCOMP#425 Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Member
|
I appreciate your eagerness to contribute to CDEPS, but AI-generated fixes like this cost us (the code maintainers) more time than they save us, so as a general policy we are now rejecting such contributions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
datm_datamode_clmncep_advancecopiedstrm_Faxa_swdnintoFaxa_swdnunconditionally at the top of the routine, so a stream configuration that provides direct and diffuse shortwave (Faxa_swdndrandFaxa_swdndf) instead of the total dereferences an unassociated pointer.Faxa_swdnis now set inside the shortwave block instead: the sum of the direct and diffuse streams when those are present, otherwise the total stream. This is the change @ekluzek posted in #425, withFaxa_swdnset first in each branch as @billsacks suggested.Specific notes
Contributors other than yourself, if any: the diff is the one proposed by @ekluzek and @billsacks in the issue.
CDEPS Issues Fixed (include github issue #): #425
Are there dependencies on other component PRs (if so list): none
Are changes expected to change answers (bfb, different to roundoff, more substantial): bit-for-bit when the total
Faxa_swdnstream is provided (Faxa_swdnreceives the same value as before). Configurations providing only the direct and diffuse streams previously failed at the unconditional copy and now getFaxa_swdn = swdndr + swdndf.Any User Interface Changes (namelist or namelist defaults changes): none
Testing performed (e.g. aux_cdeps, CESM prealpha, etc): none. I have no CESM/CIME environment or Fortran compiler on this machine, so this has not been compiled or run; it is a minimal transcription of the agreed diff. The issue also notes that nothing tests the direct/diffuse stream option (e.g. TRENDY forcing); this PR does not add such a test.
Hashes used for testing: n/a
Prepared with Claude Code (Claude Fable 5.1) and submitted on the account owner's authorisation.
🤖 Generated with Claude Code