Axis on/off modification

[le-sigwal]

Axis on/off

• added vibes::axisOff() and vibes::axisOn() methods
• use of existing "showAxis" figure poperty
• Verified in examples/all_commands.cpp

Axis dimension modification

• added vibes::axisDims() method
• use of new parameter "axisdims"
• Verified in examples/all_commands.cpp

[godardma]

Hello and thank you for your PR.

For the axis ON/OFF the "A" key of the keyboard can be used to do this operation on an active figure. From a "code" point of view it seems that the function has been defined in python but not in C++. Would it be possible for you to use the same signature ?

For the axis dimensions I am not sure that all the drawing functions support this change. For example the texts and vehicles have a

Q_ASSERT(center.size() == 2);

Would it be possible to check how these functions would behave if the dimensions are set to say 2 and 3 (as you did in the all_commands) ?

[le-sigwal]

Just commited showAxis() C++ API equivalent to corresponding Python API.
As a piece of information, added lacking bool type in Value class.
To be checked: axisDims() impacts.

[le-sigwal]

New study-case

#include "vibes.h"

int axisdims_vib_xpl(){

	vibes::beginDrawing(); // <Initializes the Vibes "connection"
	vibes::newFigure("axisdims_vib");     // <Creates a new Vibes figure;

	int fs=16;
	double length=8*((double)fs);

	double rot=0, cx=length, cy=length;
	vibes::drawText(cx, cy, "Bag Gwer", "[green]darkGreen",
			shaqParams("fontSize", fs, "fontName", "Arial"));
	cx=-length; cy= length; rot = 90;
	vibes::drawMotorBoat(cx, cy, rot, length, "darkYellow[yellow]");
	cx=-length; cy=-length; rot = 180;
	vibes::drawAUV(cx, cy, rot, length, "darkBlue[blue]");
	cx= length; cy=-length; rot = 270.0;
	vibes::drawTank(cx, cy, rot, length, "darkRed[red]");

	std::vector< std::vector<double> > polyg;
	const int dn = 3;    // point dimension
	std::vector<double> point(dn);

	point[0]= length; point[1]= length; point[2]= length; polyg.push_back(point);
	point[0]=-length; point[1]= length; point[2]= length; polyg.push_back(point);
	point[0]=-length; point[1]=-length; point[2]= length; polyg.push_back(point);
	point[0]= length; point[1]=-length; point[2]=-length; polyg.push_back(point);
	point[0]= length; point[1]= length; point[2]=-length; polyg.push_back(point);
	point[0]=-length; point[1]= length; point[2]=-length; polyg.push_back(point);
	vibes::drawLine(polyg, "lightGray");

	vibes::axisAuto();
	vibes::axisEqual("axisdims_vib");
	vibes::saveImage("./axisdims_vib.svg");

	std::vector<int> dims;
	dims.push_back(0); dims.push_back(2); dims.push_back(1);
	vibes::axisDims(dims);
	vibes::axisAuto();
	vibes::axisEqual("axisdims_vib");
	vibes::saveImage("./axisdims_vib_0-2-1.svg");

	dims[0]=1; dims[1]=0; dims[2]=2;
	vibes::axisDims(dims);
	/*vibes::axisAuto();
	vibes::axisEqual("axisdims_vib");*/
	vibes::saveImage("./axisdims_vib_1-0-2.svg");

	dims[0]=1; dims[1]=2; dims[2]=0;
	vibes::axisDims(dims);
	/*vibes::axisAuto();
	vibes::axisEqual("axisdims_vib");*/
	vibes::saveImage("./axisdims_vib_1-2-0.svg");

	dims[0]=2; dims[1]=0; dims[2]=1;
	vibes::axisDims(dims);
	/*vibes::axisAuto();
	vibes::axisEqual("axisdims_vib");*/
	vibes::saveImage("./axisdims_vib_2-0-1.svg");

	dims[0]=2; dims[1]=1; dims[2]=0;
	vibes::axisDims(dims);
	/*vibes::axisAuto();
	vibes::axisEqual("axisdims_vib");*/
	vibes::saveImage("./axisdims_vib_2-1-0.svg");

	// Back to initial graph
	dims[0]=0; dims[1]=1; dims[2]=2;
	vibes::axisDims(dims);
	/*vibes::axisAuto();
	vibes::axisEqual("axisdims_vib");*/
	vibes::saveImage("./axisdims_vib_0-1-2.svg");


	vibes::endDrawing(); // <Closes the Vibes "connection"

	return 0;
}

[godardma]

Hello,

From your study-case I see that the change of axis index/dimension does not behave consistently across all drawing functions. Since it may be confusing for users, would it be possible to do a PR with only the axis ON/OFF feature for now ?

PS : begin and end drawing are now not needed anymore since PR #128