Format cleanup 3#27
Merged
Merged
Conversation
No references to Scale_Factor_Air_Migration in model or docs - only seen in this example JSON, which is for param X_Air_Migration. Checked docs and commit history to confirm that this naming convention is consistent with other scalars, and Scale_Factor wasn't found any time recently. Updated accordingly.
JSchripsema-IDM
approved these changes
Jun 1, 2026
JSchripsema-IDM
left a comment
JSchripsema-IDM
left a comment
Collaborator
There was a problem hiding this comment.
Looks good to me as long as Kurt verifies the param name for the scaling params.
| @@ -1,3 +1,3 @@ | |||
| { | |||
| "Scale_Factor_Air_Migration": 1 | |||
Collaborator
There was a problem hiding this comment.
@kfrey-idm Can you verify that this fix is correct?
Member
There was a problem hiding this comment.
All of the multiplier parameters use lowercase x_ :
x_Air_Migration
x_Family_Migration
x_Local_Migration
x_Regional_Migration
x_Sea_Migration
x_Vector_Migration_Local
x_Vector_Migration_Regional
Collaborator
Author
There was a problem hiding this comment.
fixed my fix to lowercase ;) Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-Removed Disclaimer from README
-Removed blanks/fixed formatting issues from docs/csv/config-setup-generic.csv
-Corrected X_Air_Migration parameter name in JSON example
-Standardized file name for config-setup-generic_Serialization_Type.json and fixed typo. Deleted extra unused JSON.
-Deleted broken anchor links - not in use or needed
This should be the last of the required changes / error correction for EMOD-Generic. Remaining nice-to-haves are on EMOD-Hub/emod-hub.github.io#9