Repository navigation
chore: REUSE workflow, DCO sign-off, pid parameter tests and notes - #7
Merged
Merged
Conversation
…licence tag Signed-off-by: yallioux <yann4allioux@gmail.com>
Signed-off-by: yallioux <yann4allioux@gmail.com>
yallioux
marked this pull request as ready for review
October 7, 2026 13:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
tests/test_spdx_headers.pyheld the licence tag in one piece, soreuse lintread it as a second, invalid licence tag; the pattern is now split.REUSEworkflow runsreuse linton each push and pull request.DCO(v1.1), a section inCONTRIBUTING.md,docs/contributing/dco_howto.md,.github/dco.yml, a sign-off line in the PR template; licence text and annotation inLICENSES/andREUSE.toml.d_penand on the derivative being computed along the frame given topredict(). The frame dependence itself is not fixed here: a fix changes results.Checklist
math/pagearchitecture/pageREADME,THEORY, docstrings)REUSEworkflowtest_a_file_carries_one_licence_tag_not_a_pattern_that_looks_like_one(fails before the change); the workflow runsreuse lintCONTRIBUTING.md,docs/contributing/dco_howto.mdpid()note and teststest_pid_beats_a_linear_term_when_the_derivative_carries_the_signal,test_d_pen_is_hidden_by_the_default_penalty,test_d_pen_acts_when_the_penalty_is_explicit(they pin existing behaviour, so they pass before the change)architecture/core/06_the_spectrum_api.mdpytest). The REUSE test was written first and fails without the fix; the threepidtests describe existing behaviour and pass without it.architecture/page is updated; nomath/change.CHANGELOG.mdline per user-visible change, under[Unreleased].print()in new code.REUSE.toml.git commit -s).Pre-push verdict
pytest testspasses andreuse lintis compliant (339 of 339 files).