Add random velocity initialization functions#696
Open
streeve wants to merge 3 commits into
Open
Conversation
using counter for particle init will give non-intuitive results based on active threads
kwitaechong
reviewed
Sep 29, 2023
| \brief Initialize random particles given an initialization functor. | ||
|
|
||
| \param tag Initialization type tag. | ||
| \param create_functor A functor which populates a particle given the logical |
| template <class ExecutionSpace, class InitFunctor, class ParticleListType, | ||
| class PositionTag, class VelocityTag, class ArrayType> | ||
| int createParticles( | ||
| InitRandom tag, InitRandom, ExecutionSpace exec_space, |
Collaborator
There was a problem hiding this comment.
remove the last InitRandom? or one is for position and the other is for velocity?
| auto gen = pool.get_state(); | ||
| for ( int d = 0; d < 3; ++d ) | ||
| Cabana::get( particle, VelocityTag(), d ) = | ||
| Kokkos::rand<RandomType, double>::draw( gen, 0.0, 1.0 ); |
Collaborator
There was a problem hiding this comment.
we don't necessarily assume its value between 0.0 and 1.0. Can we assign this value from the argument?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #692
Pass a second init tag (so far just
InitRandom) to create velocities. Version forParticleListand forSlice, both fused with the particle creation kernelNeeds more testing, more convenience interfaces, potentially more thought on sampling from distributions as compared to fully random creation