Skip to content

Remove initial_guess_w_SS from default parameters#43

Merged
SeaCelo merged 3 commits into
EAPD-DRB:mainfrom
jdebacker:initial_w
Sep 17, 2025
Merged

Remove initial_guess_w_SS from default parameters#43
SeaCelo merged 3 commits into
EAPD-DRB:mainfrom
jdebacker:initial_w

Conversation

@jdebacker

Copy link
Copy Markdown
Contributor

This PR removes initial_guess_w_SS from default params per suggestions in OG-Core Issue PSLmodels/OG-Core#1039.

Note that once OG-Core is updated with PSLmodels/OG-Core#1042, OG-PHL will break without this change.

@codecov

codecov Bot commented Aug 16, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.65%. Comparing base (cfaf247) to head (4d37415).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #43   +/-   ##
=======================================
  Coverage   70.65%   70.65%           
=======================================
  Files          12       12           
  Lines         276      276           
=======================================
  Hits          195      195           
  Misses         81       81           
Flag Coverage Δ
unittests 70.65% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@SeaCelo

SeaCelo commented Sep 17, 2025

Copy link
Copy Markdown
Collaborator

Merging

@SeaCelo SeaCelo merged commit 71697bf into EAPD-DRB:main Sep 17, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants