Adding support for MPI serial library#696
Merged
jayeshkrishna merged 3 commits intoMay 22, 2026
Merged
Conversation
Since MPI_Comm_split_type() is not supported by the MPI serial library switch to MPI_Comm_dup() when using the MPI serial library
jayeshkrishna
added
the
Next Release
There was a problem hiding this comment.
Pull request overview
Adds compatibility for the MPI serial library by avoiding unsupported MPI
functions and ensuring MPI headers are included with C linkage when needed.
Changes:
- Wrap/adjust MPI header inclusion to support MPI serial builds in C++.
- Add
MPI_SERIALfallbacks for unsupported MPI calls (MPI_Comm_split_type,
MPI_Type_dup) in core code and tests. - Remove redundant direct MPI include from a unit test in favor of
pio.h.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| util/argparser.cxx | Wraps mpi.h include with extern "C" under MPI_SERIAL and uses <mpi.h>. |
| tests/cunit/test_spio_rearr_utils_gather.cpp | Uses MPI_Type_contiguous when MPI_Type_dup is unavailable in MPI serial. |
| tests/cunit/test_req_block_wait.cpp | Drops direct mpi.h include (relies on pio.h). |
| src/clib/core/util/spio_decomp_logger.hpp | Falls back to MPI_Comm_dup when MPI_Comm_split_type is unavailable in MPI serial. |
| src/clib/core/progress_engine/spio_async_tcomm.hpp | Replaces direct MPI include with pio.h (which handles MPI serial include semantics). |
| src/clib/core/pioc.cpp | Falls back to MPI_Comm_dup for node_comm when MPI_Comm_split_type is unavailable in MPI serial. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
225
to
+229
| ret = MPI_Type_dup(sendtype, &(recvtypes[i])); | ||
| #else | ||
| /* MPI serial does not support MPI_Type_dup() */ | ||
| ret = MPI_Type_contiguous(LOCAL_SZ, MPI_DOUBLE, &(recvtypes[i])); | ||
| #endif |
Contributor
Author
There was a problem hiding this comment.
Fixed and rebased branch
Since MPI serial lib does not support MPI_Type_dup() avoid duping the type in test
jayeshkrishna
force-pushed
the
jayeshkrishna/avoid_comm_split_type_for_mpiserial
branch
from
c6658b9 to
bbe81d2
Compare
Comment on lines
+1
to
+9
| #ifdef MPI_SERIAL | ||
| extern "C" { | ||
| #endif | ||
|
|
||
| #include <mpi.h> | ||
|
|
||
| #ifdef MPI_SERIAL | ||
| } | ||
| #endif |
Contributor
Author
There was a problem hiding this comment.
Fixed and rebased branch
Comment on lines
+8
to
+9
| #include "pio_config.h" | ||
| #include "pio.h" |
Contributor
Author
There was a problem hiding this comment.
Fixed and rebased branch
Including MPI header from the MPI serial library from a C++ source requires decorating the include with "extern C" blocks. So either add these decorations explicitly or use the includes in pio.h/argparser.h
jayeshkrishna
force-pushed
the
jayeshkrishna/avoid_comm_split_type_for_mpiserial
branch
from
bbe81d2 to
6edbb07
Compare
Comment on lines
+1550
to
+1554
| #ifndef MPI_SERIAL | ||
| mpierr = MPI_Comm_split_type(ios->comp_comm, MPI_COMM_TYPE_SHARED, 0, | ||
| ios->info, &(ios->node_comm)); | ||
| #else | ||
| /* MPI serial library does not support MPI_Comm_split_type() */ |
Contributor
Author
There was a problem hiding this comment.
I think we can skip adding MPI serial support for ADIOS (IMO, we are never going to need that)
Comment on lines
230
to
235
| if(ret == MPI_SUCCESS){ | ||
| ret = MPI_Type_commit(&(recvtypes[i])); | ||
| } | ||
| if(ret != MPI_SUCCESS){ | ||
| LOG_RANK0(wrank, "ERROR: Unable to create MPI dup of send type to recv doubles\n"); | ||
| LOG_RANK0(wrank, "ERROR: Unable to create recv type (same as send type) to recv doubles\n"); | ||
| return PIO_EINTERNAL; |
Contributor
Author
There was a problem hiding this comment.
This is probably a bigger change than what can fit in this PR (There are multiple cases in tests, across several tests, where we don't handle freeing of resources on fails). IMO, we can fix this (free resources when tests fail) in a later PR.
amametjanov
approved these changes
May 18, 2026
jayeshkrishna
added a commit
that referenced
this pull request
May 21, 2026
… develop (PR #696) MPI serial library does not support the following functions, * MPI_Comm_split_type() * MPI_Type_dup() The library also requires including the header as a "C header file". * jayeshkrishna/avoid_comm_split_type_for_mpiserial: Include MPI header compatible with MPI serial lib Avoid MPI_Type_dup() for mpi serial Skip MPI_Comm_split_type() for mpi serial
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MPI serial library does not support the following functions,
The library also requires including the header as a
"C header file".