Repository navigation
Reduce reset animation compositing and particle overhead - #140
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reset-card dissolution was clipped by the page scroll view and could stutter when the incoming card overlapped the particles. Render particles outside the scrolling content, apply the top fade in Metal, and replace the oversized SwiftUI refill mask with a compact native gradient mask.
Reduce particles from 24,240 to 12,155 while keeping the first card frame fully covered. Preserve the accepted drift, 1.7-second dissolve, early refill and settling motion. Normal account data and explicit reset confirmation drive the effect; no temporary demo injection remains.
Validation: 33 focused tests with isolated reset transports and GPU fixtures; localization checks (711 source templates, 743 entries); Debug arm64 development runtime verified at 0.9.2 Build 23 / internal 180. Particle/refill implementation matches the user-accepted Build 22. Side-by-side offscreen GPU P95 fell roughly 40–47%; this is not a measurement of whole-app frame rate. No real reset credits were consumed. No Release or appcast publication.
Merged to main as
baf73cb4e0a3104f4be7fcab231ab682ff94df86. PR CI and merged-main CI both passed: 805 tests, 7 skipped, 0 failures each, plus native question closure contract fixtures.