Conversation
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Visiomode 0.5+ records misses and correct rejections as a response named
"none", with the trial timeout (4–10 s) as the response time. visiomode-analysis treated these trials as having a response, so the timeouts were counted as reaction times in session/subject RT metrics and report plots, the trials got a touch position of 0, and gonogo regressors gave them a cued lever push response regressor instead of the hold regressor. In the Rett dataset this affected 264 of 872 sessions (MM213, MM263, MM361, MM365, MM367, MM372); lever push durations were not affected.Changes
_normalise_no_response()rewrites a"none"response into the form older Visiomode versions use for no response (no response object, response time -1)._flatten_trials()applies it straight after_normalise_legacy_outcome(), so response, response time, touch position, stimulus reconstruction and SDT inference all see no response;stop_timeis unchanged.summary()blanksresponse/response_timefor"none"rows in trials CSVs and DataFrames (_blank_none_responses()), so trials CSVs written by v0.4.0 and earlier give correct RTs invisiomode-analysis subjectwithout re-runningsession.resp_cuedpushdrops from 330 to 230 samples andresp_holdrises from 0 to 98."none"response, a named lever push keeping its RT, a"none"response read as no response before SDT inference, andsummary()on a v0.4.0-style CSV. The four tests that target the bug fail without the fix; the lever push test is a guard against over-correcting.## [Unreleased].